Make it possible to build the C++ version as a library #2

Closed
opened 2 years ago by nmset · 5 comments
nmset commented 2 years ago

Hi,

I tried to submit a patch but the button in the 'Pull Requests' tab is always greyed. README.adoc hints that you do not accept direct mail. How can I proceed ?

Regards.

Hi, I tried to submit a patch but the button in the 'Pull Requests' tab is always greyed. README.adoc hints that you do not accept direct mail. How can I proceed ? Regards.
Poster

Just found the upload zone below. Posting the patch, in case it might be useful.

This patch adds the following functionalities :

  1. Allows the code to be built as a dynamic library
  2. When built as a library, adds Location and ContactInfo optional fields
  3. Adds Reason optional field when built both as a library and as an executable
  4. Possibly customize signature field name
  5. Sign (incrementally?) multiple times, each one listed by pdfsig and okular

DISCLAIMER : I am not an IT professional, just a hobbyist. I wrote the patch
because it may perhaps be useful to me as a library.

Just found the upload zone below. Posting the patch, in case it might be useful. This patch adds the following functionalities : 1. Allows the code to be built as a dynamic library 2. When built as a library, adds Location and ContactInfo optional fields 3. Adds Reason optional field when built both as a library and as an executable 4. Possibly customize signature field name 5. Sign (incrementally?) multiple times, each one listed by pdfsig and okular DISCLAIMER : I am not an IT professional, just a hobbyist. I wrote the patch because it may perhaps be useful to me as a library.
Poster

Can't find the patch I just dropped below, don't know how to proceed.

Can't find the patch I just dropped below, don't know how to proceed.
p commented 2 years ago
Owner

I have written an e-mail to you, we should be able to get this resolved.

I'll try to find a way to prevent such delays in the future.

I have written an e-mail to you, we should be able to get this resolved. I'll try to find a way to prevent such delays in the future.
p commented 2 years ago
Owner

My bad. My Gitea instance was broken by some of my configuration, should be fixed now.

My bad. My Gitea instance was broken by some of my configuration, should be fixed now.
p changed title from How to submit a patch ? to Make it possible to build the C++ version as a library 2 years ago
p self-assigned this 2 years ago
p commented 2 years ago
Owner

I don't know. I've "librarified" the program in a separate branch that I've pushed now but I'm not happy with it. C++ is a horrible programming language in terms of libraries and linking.

I think I'll just close this issue for now, since according to our e-mail communication there would be no user for this (sub)change, and one can just fork-exec the current pdf-simple-sign binary to get at the same result anyway. I don't have the time to tinker with this all week.

Still, thank you, you've forced me to put everything /else/ back in order. :)

I don't know. I've "librarified" the program in a separate branch that I've pushed now but I'm not happy with it. C++ is a horrible programming language in terms of libraries and linking. I think I'll just close this issue for now, since according to our e-mail communication there would be no user for this (sub)change, and one can just fork-exec the current pdf-simple-sign binary to get at the same result anyway. I don't have the time to tinker with this all week. Still, thank you, you've forced me to put everything /else/ back in order. :)
p closed this issue 2 years ago
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.