Make it possible to build the C++ version as a library #2

New Issue

nmset · 2020-01-22T20:31:17+01:00

nmset commented

2020-01-22 20:31:17 +01:00

Hi,

I tried to submit a patch but the button in the 'Pull Requests' tab is always greyed. README.adoc hints that you do not accept direct mail. How can I proceed ?

Regards.

Hi, I tried to submit a patch but the button in the 'Pull Requests' tab is always greyed. README.adoc hints that you do not accept direct mail. How can I proceed ? Regards.

nmset commented

2020-01-28 22:52:40 +01:00

Just found the upload zone below. Posting the patch, in case it might be useful.

This patch adds the following functionalities :

Allows the code to be built as a dynamic library
When built as a library, adds Location and ContactInfo optional fields
Adds Reason optional field when built both as a library and as an executable
Possibly customize signature field name
Sign (incrementally?) multiple times, each one listed by pdfsig and okular

DISCLAIMER : I am not an IT professional, just a hobbyist. I wrote the patch
because it may perhaps be useful to me as a library.

Just found the upload zone below. Posting the patch, in case it might be useful. This patch adds the following functionalities : 1. Allows the code to be built as a dynamic library 2. When built as a library, adds Location and ContactInfo optional fields 3. Adds Reason optional field when built both as a library and as an executable 4. Possibly customize signature field name 5. Sign (incrementally?) multiple times, each one listed by pdfsig and okular DISCLAIMER : I am not an IT professional, just a hobbyist. I wrote the patch because it may perhaps be useful to me as a library.

nmset commented

2020-01-28 22:55:43 +01:00

Can't find the patch I just dropped below, don't know how to proceed.

p commented

2020-08-11 17:54:34 +02:00

I have written an e-mail to you, we should be able to get this resolved.

I'll try to find a way to prevent such delays in the future.

I have written an e-mail to you, we should be able to get this resolved. I'll try to find a way to prevent such delays in the future.

p commented

2020-08-11 22:22:17 +02:00

My bad. My Gitea instance was broken by some of my configuration, should be fixed now.

p changed title from ~~How to submit a patch ?~~ to Make it possible to build the C++ version as a library

2020-08-11 22:24:41 +02:00

p self-assigned this 2020-08-11 22:24:55 +02:00

p referenced this issue from a commit

2020-08-12 07:59:29 +02:00

C++: split out a library with a trivial interface Closes #2.

p commented

2020-08-12 08:12:37 +02:00

I don't know. I've "librarified" the program in a separate branch that I've pushed now but I'm not happy with it. C++ is a horrible programming language in terms of libraries and linking.

I think I'll just close this issue for now, since according to our e-mail communication there would be no user for this (sub)change, and one can just fork-exec the current pdf-simple-sign binary to get at the same result anyway. I don't have the time to tinker with this all week.

Still, thank you, you've forced me to put everything /else/ back in order. :)

I don't know. I've "librarified" the program in a separate branch that I've pushed now but I'm not happy with it. C++ is a horrible programming language in terms of libraries and linking. I think I'll just close this issue for now, since according to our e-mail communication there would be no user for this (sub)change, and one can just fork-exec the current pdf-simple-sign binary to get at the same result anyway. I don't have the time to tinker with this all week. Still, thank you, you've forced me to put everything /else/ back in order. :)

p closed this issue

2020-08-12 08:13:36 +02:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: p/pdf-simple-sign#2