From 80089a4d65f32ef5be31d895c59515a7e21ce84b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C5=99emysl=20Eric=20Janouch?= Date: Wed, 7 Sep 2022 12:59:50 +0200 Subject: [PATCH] xC: describe general.editor parse errors --- xC.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/xC.c b/xC.c index 75e5ea8..d65e85a 100644 --- a/xC.c +++ b/xC.c @@ -13887,22 +13887,27 @@ build_editor_command (struct app_context *ctx, const char *filename) { case 'F': str_append (&argument, filename); - break; + continue; case 'L': str_append_printf (&argument, "%zu", line_one_based); - break; + continue; case 'C': str_append_printf (&argument, "%zu", column + 1); - break; + continue; case 'B': str_append_printf (&argument, "%d", cursor + 1); - break; + continue; case '%': case ' ': str_append_c (&argument, *editor); - break; - default: - print_warning ("unknown substitution variable"); + continue; + } + + const char *p = editor; + if (soft_assert (utf8_decode (&p, strlen (p)) > 0)) + { + log_global_error (ctx, "Unknown substitution variable: %#&s", + xstrndup (editor, p - editor)); } } if (argument.len)