p
/
xK
1
1
Fork 0
Code Issues 1 Pull Requests Releases 10 Wiki Activity

degesch: never bump our own chanuser 

With IRCv3.2 echo-message, each successfully sent message would
move us to the front of the list used for chanuser autocomplete.

Such behaviour seems useless.

Also abandon the idea of bumping on other kinds of messages.
This commit is contained in:
Přemysl Eric Janouch 2021-07-24 09:22:01 +02:00
parent 7c7e12d8d5
commit 027bf8666e
Signed by: p
GPG Key ID: A0420B94F92B9493
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -1,6 +1,6 @@
1.3.0 (20xx-xx-xx) 1.3.0 (20xx-xx-xx)
* degesch: made nick autocompletion ordered by the time of last action * degesch: made nick autocompletion offer recent speakers first
1.2.0 (2021-07-08) "There Are Other Countries As Well" 1.2.0 (2021-07-08) "There Are Other Countries As Well"

7
degesch.c
View File

@ -7270,12 +7270,11 @@ irc_handle_privmsg_text (struct server *s,
char *prefixes = irc_get_privmsg_prefix char *prefixes = irc_get_privmsg_prefix
(s, str_map_find (&s->irc_users, nickname), target); (s, str_map_find (&s->irc_users, nickname), target);
// Make autocomplete offer the last speakers first on partial matches // Make autocomplete offer recent speakers first on partial matches
// TODO: might want to do this on notices as well, and the behaviour // (note that freshly joined users also move to the front)
// shouldn't change depending on whether CAP echo-message is enabled
struct user *user; struct user *user;
struct channel_user *channel_user; struct channel_user *channel_user;
if (buffer->channel if (!irc_is_this_us (s, msg->prefix) && buffer->channel
&& (user = str_map_find (&s->irc_users, nickname)) && (user = str_map_find (&s->irc_users, nickname))
&& (channel_user = irc_channel_get_user (buffer->channel, user))) && (channel_user = irc_channel_get_user (buffer->channel, user)))
{ {