Show song length in the library #2

New Issue

p · 2020-10-23T03:55:42+02:00

p commented

2020-10-23 03:55:42 +02:00

Similar to the "Current" tab. For the "Current" tab we use time but it is marked as deprecated, so prefer and parse the duration field from the lsinfo response, which may contain a fractional part.

Consider replacing the '?' for unknown times with a dash or removing it altogether.

The items array is not sufficient to store this, we need to abandon struct strv. Consider using ARRAY macros—library_tab_add() is only used to append items and the array is only reset in one place.

Similar to the "Current" tab. For the "Current" tab we use `time` but it is marked as deprecated, so prefer and parse the `duration` field from the `lsinfo` response, which may contain a fractional part. Consider replacing the '?' for unknown times with a dash or removing it altogether. The `items` array is not sufficient to store this, we need to abandon `struct strv`. Consider using `ARRAY` macros—`library_tab_add()` is only used to append items and the array is only reset in one place.

p added this to the v1.0.0 milestone 2020-10-23 03:55:42 +02:00

p self-assigned this 2020-10-23 03:55:43 +02:00

p added the

easy

label 2020-10-24 07:39:04 +02:00

p referenced this issue from a commit

2020-10-24 14:59:39 +02:00

Show song duration in the library Ideally we'd make columns configurable, which isn't trivial. This brings the "Current" and "Library" tabs closer together. Closes #2

p closed this issue

2020-10-24 14:59:39 +02:00

Sign in to join this conversation.