p
/
json-rpc-shell
1
1
Fork 0
Code Issues 8 Pull Requests Projects 1 Releases 2 Wiki Activity

Update code comments

This commit is contained in:
Přemysl Eric Janouch 2018-10-12 23:07:06 +02:00
parent d182bcef3b
commit fd17b4e504
Signed by: p
GPG Key ID: A0420B94F92B9493
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
demo-json-rpc-server.c
View File

@ -418,6 +418,7 @@ fcgi_muxer_on_message (const struct fcgi_parser *parser, void *user_data)
if (parser->type >= N_ELEMENTS (handlers) if (parser->type >= N_ELEMENTS (handlers)
|| !(handler = handlers[parser->type])) || !(handler = handlers[parser->type]))
{ {
// Responding in this way even to application records, unspecified
uint8_t content[8] = { parser->type }; uint8_t content[8] = { parser->type };
fcgi_muxer_send (self, FCGI_UNKNOWN_TYPE, parser->request_id, fcgi_muxer_send (self, FCGI_UNKNOWN_TYPE, parser->request_id,
content, sizeof content); content, sizeof content);
@ -1303,8 +1304,9 @@ json_rpc_handler_info_cmp (const void *first, const void *second)
((struct json_rpc_handler_info *) second)->method_name); ((struct json_rpc_handler_info *) second)->method_name);
} }
// TODO: a method that queues up a ping over IRC: this has to be owned by the // TODO: a method that sends a response after a certain number of seconds.
// server context as a background job that removes itself upon completion. // This has to be owned by the server context as a background job that
// removes itself upon completion.
static json_t * static json_t *
json_rpc_ping (struct server_context *ctx, json_t *params) json_rpc_ping (struct server_context *ctx, json_t *params)
@ -1479,6 +1481,8 @@ request_finish (struct request *self)
self->close_cb (self->user_data); self->close_cb (self->user_data);
} }
/// Starts processing a request. Returns false if no further action is to be
/// done and the request should be finished.
static bool static bool
request_start (struct request *self, struct str_map *headers) request_start (struct request *self, struct str_map *headers)
{ {
@ -1489,7 +1493,7 @@ request_start (struct request *self, struct str_map *headers)
// //
// However that might cause some stuff to be done twice. // However that might cause some stuff to be done twice.
// //
// Another way we could get rid off the continue_ argument is via adding // Another way we could get rid of the continue_ argument is via adding
// some way of marking the request as finished from within the handler. // some way of marking the request as finished from within the handler.
bool continue_ = true; bool continue_ = true;
@ -1551,6 +1555,9 @@ request_handler_json_rpc_push
return true; return true;
} }
// TODO: check buf.len against CONTENT_LENGTH; if it's less, then the
// client hasn't been successful in transferring all of its data
struct str response = str_make (); struct str response = str_make ();
str_append (&response, "Status: 200 OK\n"); str_append (&response, "Status: 200 OK\n");
str_append_printf (&response, "Content-Type: %s\n\n", "application/json"); str_append_printf (&response, "Content-Type: %s\n\n", "application/json");
@ -1845,6 +1852,8 @@ static void
on_client_ready (EV_P_ ev_io *watcher, int revents) on_client_ready (EV_P_ ev_io *watcher, int revents)
{ {
struct client *client = watcher->data; struct client *client = watcher->data;
// XXX: although read and write are in a sequence, if we create response
// data, we'll still likely need to go back to the event loop.
if (revents & EV_READ) if (revents & EV_READ)
if (!client_read_loop (EV_A_ client, watcher)) if (!client_read_loop (EV_A_ client, watcher))
@ -2488,6 +2497,9 @@ on_termination_signal (EV_P_ ev_signal *handle, int revents)
(void) handle; (void) handle;
(void) revents; (void) revents;
// TODO: consider quitting right away if already quitting;
// considering that this may already happen in timeout, it should be OK;
// see on_quit_timeout, just destroy all clients
initiate_quit (ctx); initiate_quit (ctx);
} }