From 5d78d1a31658f76f668eb92e367ccd600a7db8a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C5=99emysl=20Janouch?= Date: Wed, 18 Jan 2017 16:28:15 +0100 Subject: [PATCH] Fix error checking on input file --- hex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hex.c b/hex.c index b147ede..e96d704 100644 --- a/hex.c +++ b/hex.c @@ -1937,13 +1937,13 @@ main (int argc, char *argv[]) if ((input_fd = dup (STDIN_FILENO)) < 0) exit_fatal ("cannot read input: %s", strerror (errno)); close (STDIN_FILENO); - if (open ("/dev/tty", O_RDWR)) + if (open ("/dev/tty", O_RDWR) != STDIN_FILENO) exit_fatal ("cannot open the terminal: %s", strerror (errno)); } else if (argc == 1) { g_ctx.filename = xstrdup (argv[0]); - if (!(input_fd = open (argv[0], O_RDONLY))) + if ((input_fd = open (argv[0], O_RDONLY)) < 0) exit_fatal ("cannot open `%s': %s", argv[0], strerror (errno)); } else