p
/
fiv
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update comments

This commit is contained in:
Přemysl Eric Janouch 2021-11-12 06:32:40 +01:00
parent f341c8f8c3
commit 062b5757da
Signed by: p
GPG Key ID: A0420B94F92B9493
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
fastiv-io.c
View File

@ -506,11 +506,19 @@ cairo_surface_t *
fastiv_io_open(const gchar *path, GError **error) fastiv_io_open(const gchar *path, GError **error)
{ {
// TODO(p): Don't always load everything into memory, test type first, // TODO(p): Don't always load everything into memory, test type first,
// for which we only need the first 16 bytes right now. // so that we can reject non-pictures early. Wuffs only needs the first
// Though LibRaw poses an issue--we may want to try to map RAW formats // 16 bytes to make a guess right now.
// to FourCC values--many of them are compliant TIFF files. //
// We might want to employ a more generic way of magic identification, // LibRaw poses an issue--there is no good registry for identification
// and with some luck, it could even be integrated into Wuffs. // of supported files. Many of them are compliant TIFF files.
// The only good filtering method for RAWs are currently file extensions
// extracted from shared-mime-info.
//
// SVG is also problematic, an unbounded search for its root element.
// But problematic files can be assumed to be crafted.
//
// gdk-pixbuf exposes its detection data through gdk_pixbuf_get_formats().
// This may also be unbounded, as per format_check().
gchar *data = NULL; gchar *data = NULL;
gsize len = 0; gsize len = 0;
if (!g_file_get_contents(path, &data, &len, error)) if (!g_file_get_contents(path, &data, &len, error))
@ -594,8 +602,6 @@ fastiv_io_open_from_data(const char *data, size_t len, const gchar *path,
// NOTE: "It is important to note that when an image with an alpha channel is // NOTE: "It is important to note that when an image with an alpha channel is
// scaled, linear encoded, pre-multiplied component values must be used!" // scaled, linear encoded, pre-multiplied component values must be used!"
//
// We can use the pixman library to scale, PIXMAN_a8r8g8b8_sRGB.
#include <glib/gstdio.h> #include <glib/gstdio.h>
#include <png.h> #include <png.h>