wmstatus: don't spam X session logs without MPD

Allow and default to setting the MPD address to null.

CMakeLists.txt

@@ -25,7 +25,7 @@ include_directories (
 link_directories (
 	${x_LIBRARY_DIRS} ${pulse_LIBRARY_DIRS} ${dbus_LIBRARY_DIRS})
 
-option (WITH_GDM "Compile with GDM support" ${gdm_FOUND})
+option (WITH_GDM "Compile with GDM utilities" ${gdm_FOUND})
 
 # Generate a configuration file
 configure_file (${PROJECT_SOURCE_DIR}/config.h.in
@@ -33,7 +33,7 @@ configure_file (${PROJECT_SOURCE_DIR}/config.h.in
 include_directories (${PROJECT_BINARY_DIR})
 
 # Build
-set (targets wmstatus paswitch siprandom big-brother)
+set (targets wmstatus paswitch siprandom genpass)
 if ("${CMAKE_SYSTEM_NAME}" STREQUAL Linux)
 	# These use Linux i2c APIs, but can be made to work on macOS
 	list (APPEND targets brightness input-switch)
@@ -47,7 +47,7 @@ elseif (APPLE)
 	add_definitions (-D_DARWIN_C_SOURCE)
 endif ()
 
-foreach (name ${targets})
+foreach (name big-brother ${targets})
 	add_executable (${name} ${name}.c)
 endforeach ()
 
@@ -58,9 +58,10 @@ target_link_libraries (wmstatus
 add_threads (wmstatus)
 
 if (WITH_GDM)
-	include_directories (${gdm_INCLUDE_DIRS})
+	list (APPEND targets gdm-switch-user)
-	link_directories (${gdm_LIBRARY_DIRS})
 	add_executable (gdm-switch-user gdm-switch-user.c)
+	target_include_directories (gdm-switch-user PUBLIC ${gdm_INCLUDE_DIRS})
+	target_link_directories (gdm-switch-user PUBLIC ${gdm_LIBRARY_DIRS})
 	target_link_libraries (gdm-switch-user ${gdm_LIBRARIES})
 endif ()
 
@@ -71,27 +72,43 @@ include (GNUInstallDirs)
 set (SYSTEMD_UNITDIR /lib/systemd/system
 	CACHE PATH "Base directory for systemd unit files")
 
-configure_file (${PROJECT_SOURCE_DIR}/fancontrol-ng.service.in
+if ("${CMAKE_SYSTEM_NAME}" STREQUAL Linux)
-	${PROJECT_BINARY_DIR}/fancontrol-ng.service @ONLY)
+	configure_file (${PROJECT_SOURCE_DIR}/fancontrol-ng.service.in
-install (FILES fancontrol-ng.conf.example
+		${PROJECT_BINARY_DIR}/fancontrol-ng.service @ONLY)
-	DESTINATION ${CMAKE_INSTALL_DATADIR}/fancontrol-ng)
+	install (FILES fancontrol-ng.conf.example
+		DESTINATION ${CMAKE_INSTALL_DATADIR}/fancontrol-ng)
 
-configure_file (${PROJECT_SOURCE_DIR}/priod.service.in
+	configure_file (${PROJECT_SOURCE_DIR}/priod.service.in
-	${PROJECT_BINARY_DIR}/priod.service @ONLY)
+		${PROJECT_BINARY_DIR}/priod.service @ONLY)
-install (FILES priod.conf.example
+	install (FILES priod.conf.example
-	DESTINATION ${CMAKE_INSTALL_DATADIR}/priod)
+		DESTINATION ${CMAKE_INSTALL_DATADIR}/priod)
 
-# System-wide unit files should be installed under /lib and not /usr/lib
+	# System-wide unit files should be installed under /lib and not /usr/lib
-install (FILES
+	install (FILES
-	${PROJECT_BINARY_DIR}/fancontrol-ng.service
+		${PROJECT_BINARY_DIR}/fancontrol-ng.service
-	${PROJECT_BINARY_DIR}/priod.service
+		${PROJECT_BINARY_DIR}/priod.service
-	DESTINATION "${SYSTEMD_UNITDIR}")
+		DESTINATION "${SYSTEMD_UNITDIR}")
+endif ()
 
 if (WITH_GDM)
 	install (TARGETS gdm-switch-user DESTINATION ${CMAKE_INSTALL_BINDIR})
 endif ()
 
-list (REMOVE_ITEM targets big-brother)
+# These should be accessible by users, but need to touch system devices.
+# Use the setuid bit, for simplicity.
+set (SETUID "SETUID" CACHE STRING "Set this empty on permission issues")
+foreach (target brightness input-switch)
+	if (${target} IN_LIST targets)
+		list (REMOVE_ITEM targets ${target})
+		install (TARGETS ${target} DESTINATION ${CMAKE_INSTALL_BINDIR}
+			PERMISSIONS
+				OWNER_WRITE OWNER_READ OWNER_EXECUTE
+				GROUP_READ GROUP_EXECUTE
+				WORLD_READ WORLD_EXECUTE
+				${SETUID})
+	endif ()
+endforeach ()
+
 install (TARGETS ${targets} DESTINATION ${CMAKE_INSTALL_BINDIR})
 install (PROGRAMS shellify DESTINATION ${CMAKE_INSTALL_BINDIR})
 install (FILES LICENSE DESTINATION ${CMAKE_INSTALL_DOCDIR})

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2015 - 2023, Přemysl Eric Janouch <p@janouch.name>
+Copyright (c) 2015 - 2025, Přemysl Eric Janouch <p@janouch.name>
 
 Permission to use, copy, modify, and/or distribute this software for any
 purpose with or without fee is hereby granted.

README.adoc

@@ -37,7 +37,8 @@ Regular releases are sporadic.  git master should be stable enough.
 Building
 --------
 Build dependencies: CMake, pkg-config, liberty (included) +
-Runtime dependencies: libpulse, libx11, dbus-1, libgdm (optional)
+Runtime dependencies: libpulse, libx11, dbus-1 +
+Optional runtime dependencies: libgdm (gdm-switch-user)
 
  $ git clone --recursive https://git.janouch.name/p/desktop-tools.git
  $ mkdir desktop-tools/build

ddc-ci.c

@@ -46,7 +46,7 @@ log_message_custom (void *user_data, const char *quote, const char *fmt,
 static void
 wait_ms (long ms)
 {
-	struct timespec ts = { 0, ms * 1000 * 1000 };
+	struct timespec ts = { ms / 1000, (ms % 1000) * 1000 * 1000 };
 	nanosleep (&ts, NULL);
 }
 

fancontrol-ng.c

@@ -124,7 +124,7 @@ config_validate_nonnegative (const struct config_item *item, struct error **e)
 	return error_set (e, "must be non-negative");
 }
 
-static struct config_schema g_config_device[] =
+static const struct config_schema g_config_device[] =
 {
 	{ .name      = "name",
 	  .comment   = "Device identifier",
@@ -137,7 +137,7 @@ static struct config_schema g_config_device[] =
 	{}
 };
 
-static struct config_schema g_config_pwm[] =
+static const struct config_schema g_config_pwm[] =
 {
 	{ .name      = "temp",
 	  .comment   = "Path to temperature sensor output",
@@ -415,7 +415,7 @@ device_create (struct app_context *ctx, const char *path,
 // There is no room for errors in the configuration, everything must be valid.
 // Thus the reset to defaults on invalid values is effectively disabled here.
 static bool
-apply_schema (struct config_schema *schema, struct config_item *object,
+apply_schema (const struct config_schema *schema, struct config_item *object,
 	struct error **e)
 {
 	struct error *warning = NULL, *error = NULL;
@@ -445,7 +445,7 @@ static bool
 check_device_configuration (struct config_item *subtree, struct error **e)
 {
 	// Check regular fields in the device object
-	for (struct config_schema *s = g_config_device; s->name; s++)
+	for (const struct config_schema *s = g_config_device; s->name; s++)
 		if (!apply_schema (s, subtree, e))
 			return false;
 
@@ -465,7 +465,7 @@ check_device_configuration (struct config_item *subtree, struct error **e)
 	while ((pwm = str_map_iter_next (&iter)))
 	{
 		const char *subpath = iter.link->key;
-		for (struct config_schema *s = g_config_pwm; s->name; s++)
+		for (const struct config_schema *s = g_config_pwm; s->name; s++)
 			if (!apply_schema (s, pwm, &error))
 			{
 				error_set (e, "PWM `%s': %s", subpath, error->message);

gdm-switch-user.c

@@ -1,5 +1,5 @@
 // Public domain
-#include <gdm-user-switching.h>
+#include <gdm/gdm-user-switching.h>
 
 int
 main (int argc, char *argv[])

genpass.c

@@ -0,0 +1,151 @@
+/*
+ * genpass.c: password generator
+ *
+ * Copyright (c) 2025, Přemysl Eric Janouch <p@janouch.name>
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
+ * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
+ * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ *
+ */
+
+#include "config.h"
+#undef PROGRAM_NAME
+#define PROGRAM_NAME "genpass"
+#include "liberty/liberty.c"
+
+static struct str
+parse_group (const char *group)
+{
+	bool present[0x100] = {};
+	for (size_t i = 0; group[i]; i++)
+	{
+		unsigned char c = group[i];
+		if (!i || c != '-' || !group[i + 1])
+			present[c] = true;
+		else if (group[i + 1] < group[i - 1])
+			exit_fatal ("character ranges must be increasing");
+		else
+			for (c = group[i - 1]; ++c <= group[i + 1]; )
+				present[c] = true;
+	}
+
+	struct str alphabet = str_make ();
+	for (size_t i = 1; i < N_ELEMENTS (present); i++)
+		if (present[i])
+			str_append_c (&alphabet, i);
+	if (!alphabet.len)
+		exit_fatal ("empty group");
+	return alphabet;
+}
+
+static void
+parse_program_arguments (int argc, char **argv,
+	unsigned long *length, struct strv *groups, struct str *alphabet)
+{
+	static const struct opt opts[] =
+	{
+		{ 'l', "length", "CHARACTERS", 0, "set password length" },
+		{ 'd', "debug", NULL, 0, "run in debug mode" },
+		{ 'h', "help", NULL, 0, "display this help and exit" },
+		{ 'V', "version", NULL, 0, "output version information and exit" },
+		{ 0, NULL, NULL, 0, NULL }
+	};
+
+	struct opt_handler oh =
+		opt_handler_make (argc, argv, opts, "GROUP...", "Password generator.");
+
+	int c;
+	while ((c = opt_handler_get (&oh)) != -1)
+	switch (c)
+	{
+	case 'l':
+		if (!xstrtoul (length, optarg, 10) || *length <= 0)
+			print_fatal ("invalid length argument");
+		break;
+	case 'd':
+		g_debug_mode = true;
+		break;
+	case 'h':
+		opt_handler_usage (&oh, stdout);
+		exit (EXIT_SUCCESS);
+	case 'V':
+		printf (PROGRAM_NAME " " PROGRAM_VERSION "\n");
+		exit (EXIT_SUCCESS);
+	default:
+		print_error ("wrong options");
+		opt_handler_usage (&oh, stderr);
+		exit (EXIT_FAILURE);
+	}
+
+	argc -= optind;
+	argv += optind;
+
+	for (int i = 0; i < argc; i++)
+	{
+		struct str alphabet = parse_group (argv[i]);
+		strv_append_owned (groups, str_steal (&alphabet));
+	}
+
+	bool present[0x100] = {};
+	for (size_t i = 0; i < groups->len; i++)
+		for (size_t k = 0; groups->vector[i][k]; k++)
+		{
+			unsigned char c = groups->vector[i][k];
+			if (present[c])
+				exit_fatal ("groups are not disjunct");
+			present[c] = true;
+		}
+	for (size_t i = 1; i < N_ELEMENTS (present); i++)
+		if (present[i])
+			str_append_c (alphabet, i);
+
+	if (groups->len > *length)
+		exit_fatal ("the requested length is less than the number of groups");
+	if (!groups->len)
+	{
+		opt_handler_usage (&oh, stderr);
+		exit (EXIT_FAILURE);
+	}
+
+	opt_handler_free (&oh);
+}
+
+int
+main (int argc, char *argv[])
+{
+	unsigned long length = 8;
+	struct strv groups = strv_make ();
+	struct str alphabet = str_make ();
+	parse_program_arguments (argc, argv, &length, &groups, &alphabet);
+
+	unsigned seed = 0;
+	if (!random_bytes (&seed, sizeof seed, NULL))
+		exit_fatal ("failed to initialize random numbers");
+	srand (seed);
+
+	// Select from a joined alphabet, but make sure all groups are represented.
+	struct str candidate = str_make ();
+	while (true)
+	{
+restart:
+		for (size_t i = length; i--; )
+			str_append_c (&candidate, alphabet.str[rand () % alphabet.len]);
+		for (size_t i = 0; i < groups.len; i++)
+			if (!strpbrk (candidate.str, groups.vector[i]))
+			{
+				str_reset (&candidate);
+				goto restart;
+			}
+
+		printf ("%s\n", candidate.str);
+		return 0;
+	}
+}

paswitch.c

@@ -290,7 +290,7 @@ on_sink_info (pa_context *context, const pa_sink_info *info, int eol,
 			sink->ports_len++;
 
 		struct port *port = sink->ports =
-			xcalloc (sizeof *sink->ports, sink->ports_len);
+			xcalloc (sink->ports_len, sizeof *sink->ports);
 		for (struct pa_sink_port_info **iter = info->ports; *iter; iter++)
 		{
 			port->name = xstrdup ((*iter)->name);

wmstatus-weather.pl

@@ -20,7 +20,8 @@ my %legends;
 sub retrieve_legends {
 	# HTTP/Tiny supports TLS, but with non-core IO::Socket::SSL, so use cURL
 	open(my $sock, '-|', 'curl', '-sSA', $agent,
-		"$base/weathericon/2.0/legends.txt") or return $!;
+		'https://raw.githubusercontent.com/' .
+		'metno/weathericons/main/weather/legend.csv') or return $!;
 	while (local $_ = <$sock>) { $legends{$1} = $2 if /^(.+?),(.+?),/ }
 	close($sock);
 }

wmstatus.conf.example

@@ -0,0 +1,63 @@
+# vim: set ft=libertyconf:
+keys = {
+	# This key should be labeled L on normal Qwert[yz] layouts
+	"Mod4 n"                       = "exec dm-tool lock" # gdm-switch-user
+
+	# xmodmap grep -e Alt_R -e Meta_R -e ISO_Level3_Shift -e Mode_switch
+	# can be used to figure out which modifier is AltGr
+
+	"Mod4       Up"                = "mpd-play-toggle"
+	"Mod4       Down"              = "mpd stop"
+	"Mod4       Left"              = "mpd previous"
+	"Mod4       Right"             = "mpd next"
+	"Mod4 Shift Left"              = "mpd seekcur -10"
+	"Mod4 Shift Right"             = "mpd seekcur +10"
+	"XF86AudioPlay"                = "mpd-play-toggle"
+	"XF86AudioPrev"                = "mpd previous"
+	"XF86AudioNext"                = "mpd next"
+
+	"Mod4 F1"                      = "xkb-lock-group 0"
+	"Mod4 F2"                      = "xkb-lock-group 1"
+	"Mod4 F3"                      = "xkb-lock-group 2"
+	"Mod4 F4"                      = "xkb-lock-group 3"
+
+	"Mod4 Control       F1"        = "exec input-switch vga 1"
+	"Mod4 Control Shift F1"        = "exec input-switch vga 2"
+	"Mod4 Control       F2"        = "exec input-switch dvi 1"
+	"Mod4 Control Shift F2"        = "exec input-switch dvi 2"
+	"Mod4 Control       F3"        = "exec input-switch hdmi 1"
+	"Mod4 Control Shift F3"        = "exec input-switch hdmi 2"
+	"Mod4 Control       F4"        = "exec input-switch dp 1"
+	"Mod4 Control Shift F4"        = "exec input-switch dp 2"
+
+	"Mod4 Home"                    = "exec brightness +10"
+	"Mod4 End"                     = "exec brightness -10"
+	"XF86MonBrightnessUp"          = "exec brightness +10"
+	"XF86MonBrightnessDown"        = "exec brightness -10"
+
+	# We need to wait a little while until user releases the key
+	"Mod4       F5"    = "exec sh -c 'sleep 1; xset dpms force standby'"
+	"Mod4 Shift F5"    = "insomnia"
+	"Mod4       Pause" = "exec sh -c 'sleep 1; xset dpms force standby'"
+	"Mod4 Shift Pause" = "insomnia"
+
+	"Mod4       Insert"            = "audio-switch"
+	"Mod4       Delete"            = "audio-mute"
+	"Mod4 Shift Delete"            = "audio-mic-mute"
+	"Mod4       Page_Up"           = "audio-volume +5"
+	"Mod4 Shift Page_Up"           = "audio-volume +1"
+	"Mod4       Page_Down"         = "audio-volume -5"
+	"Mod4 Shift Page_Down"         = "audio-volume -1"
+	"        XF86AudioRaiseVolume" = "audio-volume +5"
+	"Shift   XF86AudioRaiseVolume" = "audio-volume +1"
+	"        XF86AudioLowerVolume" = "audio-volume -5"
+	"Shift   XF86AudioLowerVolume" = "audio-volume -1"
+	"        XF86AudioMute"        = "audio-mute"
+	"        XF86AudioMicMute"     = "audio-mic-mute"
+
+	"Control XF86AudioRaiseVolume" = "noise-adjust +1"
+	"Control XF86AudioLowerVolume" = "noise-adjust -1"
+
+	# Turns on or off Pioneer integrated amplifiers
+	"Mod4 Control Delete" = "exec elksmart-comm --nec A538"
+}